perf(range): avoid eager ok_or in gen_range_timestamp - #25308
Merged
Merged
Conversation
…mp generation Replace per-row ok_or(exec_datafusion_err!(...)) with ok_or_else in gen_range_timestamp so the success path no longer allocates a DataFusionError for every generated row (~5x on 100k rows). Add a criterion bench for the timestamp range path.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25308 +/- ##
==========================================
- Coverage 82.33% 82.32% -0.01%
==========================================
Files 1137 1137
Lines 431884 431887 +3
Branches 431884 431887 +3
==========================================
- Hits 355586 355567 -19
- Misses 54805 54822 +17
- Partials 21493 21498 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Replace per-row
ok_or(exec_datafusion_err!(...))withok_or_elseingen_range_timestampso the success path no longer allocates a DataFusionError for every generated row (speed up ~5x on 100k rows). Add a criterion bench for the timestamp range path.Which issue does this PR close?
Rationale for this change
Avoid eager ok_or on the hot path.
What changes are included in this PR?
Replaces eager ok_or with lazy ok_or_else.
What is the testing strategy for this PR?
Added a criterion bench.
Are there any user-facing changes?
No